fix(@angular-devkit/build-angular): expand jest and jest-environment-jsdom to allow version 30
#30761
Conversation
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
alan-agius4
changed the title
jest and jest-environment-jsdom to allow version 30jest and jest-environment-jsdom to allow version 30
alan-agius4
removed
the
action: review
…nt-jsdom` to allow version 30 This commit expands the peer deps of these dependencies to allow version 30. Closes angular#30760
|
|
||
| export default async function (): Promise<void> { | ||
| await applyJestBuilder(); | ||
| await silentNpm('install', 'jest@29.5.0', 'jest-environment-jsdom@29.5.0', '--save-dev'); |
There was a problem hiding this comment.
Question: Do we need to continue to support v29? Since this is still experimental, I don't think we're on the hook for backwards compatibility yet and it's probably reasonable to limit this to the latest major unless we have reason to believe that will be exceptionally difficult for users to adopt.
There was a problem hiding this comment.
So it seems that this would need further investigation to get version 30 to work. Let's have a chat about this offline to see the next steps for this builder.
|
@dgp1130 @alan-agius4 When support for Jest v30 could be merged? |
|
This would require some further investigation and work to land as some tests are failing with the latest jest version. |
|
@alan-agius4 Sure. I understand that. But the question is - when? It would be nice to know what are the plans for that support :) Don't want to check this PR every day :D |
on the right there is a "Subscribe" button where you can opt in to getting updates on the status and comments of this PR to avoid having to check manually. with that being said a timeline would be pretty cool as this is holding up my teams update to Jest 30 =) |
|
We haven't had a detailed investigation or discussion just yet. When we have more information to share, we'll share it. Also just a friendly reminder that the |
This commit expands the peer deps of these dependencies to allow version 30.
Closes #30760